macros: accept paths in wrap_x macros #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
wrap-paths
branch
3 times, most recently
from
7b5b614
to
8fa4ea8
Compare
davidhewitt
force-pushed
the
wrap-paths
branch
2 times, most recently
from
62b2395
to
09d2dfc
Compare
davidhewitt
force-pushed
the
wrap-paths
branch
from
09d2dfc
to
ff37f24
Compare
davidhewitt
pushed a commit
that referenced
this pull request
Jun 21, 2022
* remove workaround section in module.md that is no longer needed after merging #2081 * update changelong * revert CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1709
Reimplements
wrap_pyfunctionandwrap_pymoduleas proc macros. This enables them to take paths as well as idents and also enables dropping thepastedependency.TODO needs tests before merging.EDIT: tested viapyo3-pytests.