pytype: resurrect (deprecated) PyType::is_instance #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
resurrect-type-is-instance
branch
from
3705ee4
to
b396468
Compare
davidhewitt
force-pushed
the
resurrect-type-is-instance
branch
from
b396468
to
b56d492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up to #1985 to restore
PyType::is_instancein a deprecated state.I realised that if we just straight-up remove this method without a deprecation cycle, users will likely experience runtime failures because
type.is_instance(obj)will continue to compile but selectPyAny::is_instanceinstead thanks toPyTypedereferencing toPyAny.Hence this PR resurrects
PyType::is_instancein a deprecated state so that users have some time to migrate away.