ffi: restore _PyImport_FindExtensionObject on Python 3.10 #1942
Conversation
|
I rely on this symbol in PyOxidizer on Windows. So the missing symbol is potentially blocking PyOxidizer from supporting Python 3.10 on Windows. I might be able to work around by defining the symbol reference in my crate. But I can't recall if Cargo allows you to do this without putting up a fight. So having this in a pyo3 release ASAP would be preferred. I'm tentatively planning to release PyOxidizer this weekend. But life may intervene even if I'm blocked on pyo3: so no pressure! |
There was a problem hiding this comment.
👍 Happy to get this into a release soon - as per #1921 I just need to write some documentation (which I'm halfway through and may finish tomorrow). So we may not release tomorrow, but perhaps within a week.
See coments below for a couple of tweaks please...
indygreg
force-pushed
the
restore-findextensionobject
branch
from
1cefc7b
to
7377b2a
Compare
This symbol was initially removed from 3.10. But it was restored late in the 3.10 development cycle in time for 3.10.0. See https://bugs.python.org/issue45307. It is slated for removal in 3.11.
indygreg
force-pushed
the
restore-findextensionobject
branch
from
7377b2a
to
a5f804e
Compare
|
I force pushed with a rebase + incorporation of the suggested changes. |
This symbol was initially removed from 3.10. But it was restored
late in the 3.10 development cycle in time for 3.10.0. See
https://bugs.python.org/issue45307.