pymethods: support __call__ proto #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
call-proto
branch
2 times, most recently
from
31864ec
to
146af73
Compare
|
Added a second commit to add support for |
davidhewitt
force-pushed
the
call-proto
branch
3 times, most recently
from
474759c
to
1d2437d
Compare
davidhewitt
force-pushed
the
call-proto
branch
from
1d2437d
to
0e0e6f8
Compare
|
Anyone wanting to review this one before I merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1884
Implements
#[pymethods]formfn __call__as the preferred way to make callable objects, changing the guide and a little bit of other cleanup at the same time.