pymethods: make inventory optional #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
multiple-pymethods
branch
from
dbf1994
to
1feefb5
Compare
Merged
|
After #1458 is merged I will rebase on it, which should fix the issues I put into the CI workflow 馃槃 |
davidhewitt
force-pushed
the
multiple-pymethods
branch
from
1feefb5
to
977735d
Compare
davidhewitt
force-pushed
the
multiple-pymethods
branch
from
8b5414e
to
bb6d4df
Compare
|
I've pushed a bunch of documentation tweaks. Unless any changes are needed to those, this PR should be good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
inventoryis opt-in (via themultiple-pymethodsfeature) and only needed if you want to have multiple#[pymethods]for the same#[pyclass].This is breaking, so we could make it opt-out. However I think most users won't use multiple
#[pymethods]per class so will enjoy the reduced dependencies & faster compile times without noticing anything changed 馃槃I plan to push a number of updates to the guide before this PR is ready to be merged. (e.g. information about the feature, migration guide etc.)