pycfunction: take &'static str arguments to new #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
pycfunction-static
branch
from
a8b51a3
to
55aec97
Compare
messense
reviewed
Feb 27, 2021
kngwyu
reviewed
Feb 27, 2021
Co-authored-by: messense <messense@icloud.com>
davidhewitt
force-pushed
the
pycfunction-static
branch
from
a7d33dd
to
1aa1e91
Compare
|
Changes pushed - thanks both for the reviews! |
messense
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1446 to refactor
PyCFunctiona little bit to re-use code and get rid of onetransmutecall at the same time.I had to change the
nameanddocarguments toPyCFunction::new()to take&'static strinstead of just&str. This is a good change in my opinion because the underlying Python APIs need'staticdata anyway. Previously we always had to copy the string and leak the copy; now we can forward the pointer to the underlying string (as long as it's a valid c-string).