Refactor build rs #1350
Merged
Refactor build rs #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
refactor-build-rs
branch
6 times, most recently
from
66a3c3f
to
181585d
Compare
davidhewitt
force-pushed
the
refactor-build-rs
branch
from
181585d
to
a350dd2
Compare
kngwyu
approved these changes
Jan 1, 2021
build.rs
Outdated
| static SYSCONFIG_FLAGS: [&str; 7] = [ | ||
| "Py_USING_UNICODE", | ||
| "Py_UNICODE_WIDE", | ||
| type BuildFlag = &'static str; |
There was a problem hiding this comment.
Is this really so meaningful?
I think maybe struct BuildFlags(HashSet<&'static str>) would be a better abstraction.
Then we can move BUILD_FLAGS into impl BuildFlags block.
|
Pushed a commit to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some simplifications to build.rs, based on #1337:
PYO3_CROSS_INCLUDE_DIRheader parsing