New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inline fn instead of macro_rules to construct PyMemberDef #1346

Merged

davidhewitt merged 1 commit into master from py39-dict-and-weakref-tweaks

Dec 28, 2020

Member

kngwyu commented Dec 28, 2020

A tweak for #1342.
As I commented in #1345, I don't have any strict rule about macro vs inline fn so rejecting is OK if you don't like this.


          Use inline fn instead of macro_rules to construct PyMemberDef

2e024b5

Member

davidhewitt commented Dec 28, 2020

It's one line shorter, let's use it 😂

davidhewitt approved these changes

View reviewed changes

davidhewitt merged commit acbfaf4 into master

messense deleted the py39-dict-and-weakref-tweaks branch

March 18, 2021 02:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment