Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deny all warnings #1323

Merged
merged 3 commits into from
Dec 19, 2020
Merged

ci: deny all warnings #1323

merged 3 commits into from
Dec 19, 2020

Conversation

davidhewitt
Copy link
Member

I think that I've seen our CI allows some warnings to slip through, so I want to deny all these...

@davidhewitt
Copy link
Member Author

Please don't merge until pypy CI is fixed, as I am sure I have seen warnings for pypy. (looks like there's a bug in setup-python at the moment: actions/setup-python#171)

@davidhewitt davidhewitt force-pushed the deny-warnings branch 3 times, most recently from cae295f to dfe3303 Compare December 18, 2020 23:49
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kngwyu kngwyu merged commit 58ade65 into PyO3:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants