Add optional support for conversion from Hashbrown types #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds optional support for conversion from hashbrown's [1] HashMap [2] and HashSet [3] types. The HashMap and HashSet implementation in std::collections is a copy from HashBrown, but Hashbrown still provides some features over the std::collections version. Primarily this is rayon support and also using a default hasher which is faster (although not DOS resistent). The hashbrown versions provide a drop in replacement over std::collections to get these features. To take advantage of native type conversion in PyO3 this commit adds hashbrown as an optional dependency and when the feature is enabled the traits for going between python and hashbrown::HashMap and hashbrown::HashSet are available. This is handy for users of hashbrown which have to inline these conversions manually in functions that take dicts as args. [1] https://github.com/rust-lang/hashbrown [2] https://docs.rs/hashbrown/0.8.2/hashbrown/struct.HashMap.html [3] https://docs.rs/hashbrown/0.8.2/hashbrown/struct.HashSet.html
|
Thanks, could you please add a |
Sure thing, added in: 659d24e |
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Sep 19, 2020
Since PyO3 0.12.0 the trait implementations for converting from hashbrown's HashMap and HashSet types. [1] This commit leverage this so we do not have to internally convert these objects to and from python types. [1] PyO3/pyo3#1114
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Oct 13, 2020
Since PyO3 0.12.0 the trait implementations for converting from hashbrown's HashMap and HashSet types. [1] This commit leverage this so we do not have to internally convert these objects to and from python types. [1] PyO3/pyo3#1114
mtreinish
added a commit
to Qiskit/rustworkx
that referenced
this pull request
Oct 18, 2020
* Rely on PyO3 type conversion for HashMap and HashSet Since PyO3 0.12.0 the trait implementations for converting from hashbrown's HashMap and HashSet types. [1] This commit leverage this so we do not have to internally convert these objects to and from python types. [1] PyO3/pyo3#1114 * Revert PyDiGraph compose to use PyObject return This commit reverts the change for the PyDiGraph.compose() method to use a PyObject return type of a PyDict again. Doing the HashMap return resulted in a double iteration over the output map, the first to convert NodeIndex to a usize and the second in the PyO3 wrapper to convert the HashMap to a PyDict in the python ffi. Returning a PyObject enables to do the NodeIndex to usize conversion and PyDict generation at the same time with a single loop over the contents. * Fix PyGraph.compose() too * Revert to PyObject for graph_greedy_color * Standardize naming on weight_transform_callable
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds optional support for conversion from hashbrown's [1]
HashMap [2] and HashSet [3] types. The HashMap and HashSet implementation
in std::collections is a copy from HashBrown, but Hashbrown still
provides some features over the std::collections version. Primarily this
is rayon support and also using a default hasher which is faster
(although not DOS resistant). The hashbrown versions provide a drop in
replacement over std::collections to get these features. To take
advantage of native type conversion in PyO3 this commit adds hashbrown
as an optional dependency and when the feature is enabled the traits for
going between python and hashbrown::HashMap and hashbrown::HashSet are
available. This is handy for users of hashbrown which have to inline
these conversions manually in functions that take dicts as args.
[1] https://github.com/rust-lang/hashbrown
[2] https://docs.rs/hashbrown/0.8.2/hashbrown/struct.HashMap.html
[3] https://docs.rs/hashbrown/0.8.2/hashbrown/struct.HashSet.html