Skip to content

Commit

Permalink
add regression test for PEP 587
Browse files Browse the repository at this point in the history
  • Loading branch information
davidhewitt committed May 14, 2022
1 parent 03cb561 commit e6ddbdc
Show file tree
Hide file tree
Showing 4 changed files with 81 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added the internal `IntoPyResult` trait to give better error messages when function return types do not implement `IntoPy`. [#2326](https://github.com/PyO3/pyo3/pull/2326)
- Add `PyDictKeys`, `PyDictValues` and `PyDictItems` Rust types to represent `dict_keys`, `dict_values` and `dict_items` types. [#2358](https://github.com/PyO3/pyo3/pull/2358)
- Add an experimental `generate-import-lib` feature to support auto-generating non-abi3 python import libraries for Windows targets. [#2364](https://github.com/PyO3/pyo3/pull/2364)
- Add FFI definition `Py_ExitStatusException`. [#2370](https://github.com/PyO3/pyo3/pull/2370)

### Changed

Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Expand Up @@ -49,6 +49,7 @@ send_wrapper = "0.5"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0.61"
rayon = "1.0.2"
widestring = "0.5.1"

[build-dependencies]
pyo3-build-config = { path = "pyo3-build-config", version = "0.16.4", features = ["resolve-config"] }
Expand Down
2 changes: 1 addition & 1 deletion pyo3-ffi/src/cpython/pylifecycle.rs
Expand Up @@ -23,7 +23,7 @@ extern "C" {

pub fn Py_RunMain() -> c_int;

// skipped Py_ExitStatusException
pub fn Py_ExitStatusException(status: PyStatus) -> !;

// skipped _Py_RestoreSignals

Expand Down
78 changes: 78 additions & 0 deletions tests/test_pep_587.rs
@@ -0,0 +1,78 @@
#![cfg(not(any(PyPy, Py_LIMITED_API)))]

use pyo3::ffi;
use widestring::WideCString;

#[test]
fn test_default_interpreter() {
macro_rules! ensure {
($py_call:expr) => {{
let status = $py_call;
unsafe {
if ffi::PyStatus_Exception(status) != 0 {
ffi::Py_ExitStatusException(status);
}
}
}};
}

let mut preconfig = unsafe { std::mem::zeroed() };

unsafe { ffi::PyPreConfig_InitPythonConfig(&mut preconfig) };
preconfig.utf8_mode = 1;

ensure!(unsafe { ffi::Py_PreInitialize(&preconfig) });

let mut config = unsafe { std::mem::zeroed() };
unsafe { ffi::PyConfig_InitPythonConfig(&mut config) };

// Require manually calling _Py_InitializeMain to exercise more ffi code
config._init_main = 0;

// Set program_name as regression test for #2370
#[cfg(all(Py_3_10, windows))]
{
use libc::wchar_t;
use std::ffi::OsStr;
use std::os::windows::ffi::OsStrExt;
let mut value: Vec<wchar_t> = OsStr::new("some_test\0").encode_wide().collect();

unsafe {
ffi::PyConfig_SetString(
&mut config,
&mut config.program_name,
value.as_ptr(),
);
}
}
#[cfg(all(Py_3_10, unix))]
{
unsafe {
ffi::PyConfig_SetBytesString(
&mut config,
&mut config.program_name,
"some_test\0".as_ptr().cast(),
);
}
}

ensure!(unsafe { ffi::Py_InitializeFromConfig(&config) });

// The GIL is held.
assert_eq!(unsafe { ffi::PyGILState_Check() }, 1);

// Now proceed with the Python main initialization. This will initialize
// importlib. And if the custom importlib bytecode was registered above,
// our extension module will get imported and initialized.
ensure!(unsafe { ffi::_Py_InitializeMain() });

// The GIL is held after finishing initialization.
assert_eq!(unsafe { ffi::PyGILState_Check() }, 1);

// Confirm program name set above was picked up correctly
#[cfg(Py_3_10)]
{
let program_name = unsafe { WideCString::from_ptr_str(ffi::Py_GetProgramName().cast()) };
assert_eq!(program_name.to_string().unwrap(), "some_test");
}
}

0 comments on commit e6ddbdc

Please sign in to comment.