Skip to content

Commit

Permalink
pyo3-build-config: Use "m" ABI tag for libpython 3.7 by default
Browse files Browse the repository at this point in the history
According to https://bugs.python.org/issue36707, this tag is useless
since version 3.4, but also the default until version 3.8.

For example, Debian 10 ships `libpython3.7m.so`.
  • Loading branch information
ravenexp committed Apr 9, 2022
1 parent 1971dd7 commit cb587a3
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions pyo3-build-config/src/impl_.rs
Expand Up @@ -1505,7 +1505,15 @@ fn default_lib_name_unix(
match implementation {
PythonImplementation::CPython => match ld_version {
Some(ld_version) => format!("python{}", ld_version),
None => format!("python{}.{}", version.major, version.minor),
None => {
if version > PythonVersion::PY37 {
// PEP 3149 ABI version tags are finally gone
format!("python{}.{}", version.major, version.minor)
} else {
// Work around https://bugs.python.org/issue36707
format!("python{}.{}m", version.major, version.minor)
}
}
},
PythonImplementation::PyPy => {
if version >= (PythonVersion { major: 3, minor: 9 }) {
Expand Down Expand Up @@ -2142,10 +2150,15 @@ mod tests {
#[test]
fn default_lib_name_unix() {
use PythonImplementation::*;
// Defaults to pythonX.Y for CPython
// Defaults to python3.7m for CPython 3.7
assert_eq!(
super::default_lib_name_unix(PythonVersion { major: 3, minor: 7 }, CPython, None),
"python3.7",
"python3.7m",
);
// Defaults to pythonX.Y for CPython 3.8+
assert_eq!(
super::default_lib_name_unix(PythonVersion { major: 3, minor: 8 }, CPython, None),
"python3.8",
);
assert_eq!(
super::default_lib_name_unix(PythonVersion { major: 3, minor: 9 }, CPython, None),
Expand Down

0 comments on commit cb587a3

Please sign in to comment.