Merge pull request #2198 from PanQL/fix-interpreter-script

use platform.system to check if it is on windows
PyO3 · Mar 3, 2022 · 6fda258 · 6fda258
2 parents 5f39e48 + 84cb8cd
commit 6fda258
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,12 @@ PyO3 versions, please see the [migration guide](https://pyo3.rs/latest/migration
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- Fix incorrect platform detection for Windows in `pyo3-build-config`. [#2198](https://github.com/PyO3/pyo3/pull/2198)
+
 ## [0.16.0] - 2022-02-27
 
 ### Packaging

diff --git a/pyo3-build-config/src/impl_.rs b/pyo3-build-config/src/impl_.rs
@@ -188,7 +188,7 @@ def print_if_set(varname, value):
         print(varname, value)
 
 # Windows always uses shared linking
-WINDOWS = hasattr(platform, "win32_ver")
+WINDOWS = platform.system() == "Windows"
 
 # macOS framework packages use shared linking
 FRAMEWORK = bool(get_config_var("PYTHONFRAMEWORK"))