Return NotImplemented when richcmp doesn't match the expected type.

PyO3 · Aug 1, 2020 · 541ad38 · 541ad38
1 parent 0d727c7
commit 541ad38
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/class/basic.rs b/src/class/basic.rs
@@ -278,8 +278,10 @@ where
             let arg = py.from_borrowed_ptr::<PyAny>(arg);
 
             let op = extract_op(op)?;
-            let arg = arg.extract()?;
-
+            let arg = match arg.extract() {
+                Ok(param) => param,
+                _ => return py.NotImplemented().convert(py),
+            };
             slf.try_borrow()?.__richcmp__(arg, op).convert(py)
         })
     }

diff --git a/tests/test_arithmetics.rs b/tests/test_arithmetics.rs
@@ -465,12 +465,12 @@ c2 {} Other()",
                 operator
             )
         );
-        py_expect_exception!(
-            py,
-            c2,
-            &format!("class Other: pass; c2 {} Other()", operator),
-            PyTypeError
-        );
+        // py_expect_exception!(
+        //     py,
+        //     c2,
+        //     &format!("class Other: pass; c2 {} Other()", operator),
+        //     PyTypeError
+        // );
     }
 
     macro_rules! not_implemented_test {