Merge pull request #2715 from messense/fix-pymodule-filename-on-pypy

Disable `PyModule::filename` on PyPy
PyO3 · Nov 1, 2022 · 24dabc5 · 24dabc5
2 parents d7b05cb + 736e975
commit 24dabc5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/newsfragments/2715.fixed.md b/newsfragments/2715.fixed.md
@@ -0,0 +1 @@
+Disable `PyModule::filename` on PyPy
diff --git a/pyo3-ffi/src/moduleobject.rs b/pyo3-ffi/src/moduleobject.rs
@@ -32,6 +32,7 @@ extern "C" {
     #[cfg(not(all(windows, PyPy)))]
     #[deprecated(note = "Python 3.2")]
     pub fn PyModule_GetFilename(arg1: *mut PyObject) -> *const c_char;
+    #[cfg(not(PyPy))]
     pub fn PyModule_GetFilenameObject(arg1: *mut PyObject) -> *mut PyObject;
     // skipped non-limited _PyModule_Clear
     // skipped non-limited _PyModule_ClearDict

diff --git a/src/types/module.rs b/src/types/module.rs
@@ -203,7 +203,7 @@ impl PyModule {
     /// Returns the filename (the `__file__` attribute) of the module.
     ///
     /// May fail if the module does not have a `__file__` attribute.
-    #[cfg(not(all(windows, PyPy)))]
+    #[cfg(not(PyPy))]
     pub fn filename(&self) -> PyResult<&str> {
         unsafe {
             self.py()