Add support for cross compiling PyPy wheels #687
Merged
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: 2278c17 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/61949a9fd06124000786fdea |
messense
commented
Nov 17, 2021
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Build Wheels | ||
| run: | | ||
| echo 'curl -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable --profile minimal | ||
| source ~/.cargo/env | ||
| rustup target add ${{ matrix.platform.target }} | ||
| export PYO3_CROSS_LIB_DIR=/opt/python/${{ matrix.platform.abi }}/lib | ||
| export PYO3_CROSS_LIB_DIR=/opt/python/${{ matrix.platform.abi }} |
There was a problem hiding this comment.
@davidhewitt For #681 I'd like to change pyo3 to support PYO3_CROSS_LIB_DIR without the lib part, what do you think?
There was a problem hiding this comment.
cc @aganders3 in case you are interested in for PyO3/pyo3#1996
|
I'm gonna merge this with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #681