feat: Organization/Repository custom properties #2968
Conversation
jackylamhk
force-pushed
the
feat/repo-custom-properties
branch
from
5cf58d4
to
2f33a50
Compare
There was a problem hiding this comment.
Would you mind implementing organization custom properties?
https://docs.github.com/en/rest/orgs/custom-properties
If not don't doubt to tag me in, I'd love this feature as my org recently moved to Github and find this valuable.
Thank you for your work!
github/Repository.py
Outdated
| """ | ||
| url = f"{self.url}/properties/values" | ||
| _, data = self._requester.requestJsonAndCheck("GET", url) | ||
| return {p["property_name"]: p["value"] for p in data} |
There was a problem hiding this comment.
I would return the data directly as expected by the docs
There was a problem hiding this comment.
It looks like the repo / and /properties/values return different schemas - I would prefer sticking to dict[str, *] to make it easier to work with. Let me know if you think otherwise :)
|
Closes #2895 |
Done - didn't realize it's already returned in the root GET. You're welcome! |
jackylamhk
force-pushed
the
feat/repo-custom-properties
branch
from
54a16aa
to
3bbae39
Compare
jackylamhk
changed the title
There might have been a misunderstanding here, I meant implementing |
jackylamhk
changed the title
My bad, I was looking at the issue you linked earlier. I've written a new Considering using the same class for the repo method returns too. |
jackylamhk
force-pushed
the
feat/repo-custom-properties
branch
from
fd2c138
to
fc93c6a
Compare
| @@ -1326,6 +1328,35 @@ def get_dependabot_alerts( | |||
| url_parameters, | |||
| ) | |||
|
|
|||
| def get_all_custom_properties(self) -> PaginatedList[OrganizationCustomProperty]: | |||
There was a problem hiding this comment.
shall we rename this?
| def get_all_custom_properties(self) -> PaginatedList[OrganizationCustomProperty]: | |
| def get_custom_properties(self) -> PaginatedList[OrganizationCustomProperty]: |
Fixes #2895.