Return added team membership instance #2956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdelic
force-pushed
the
feature/add-team-return-values
branch
from
bebcdb4
to
f5d5190
Compare
… value, but we didn't honor it so far
jdelic
force-pushed
the
feature/add-team-return-values
branch
from
f5d5190
to
20d17da
Compare
EnricoMi
requested changes
May 21, 2024
| "DELETE", | ||
| self.url, | ||
| ) | ||
| return status == 204 |
There was a problem hiding this comment.
This is bad practise: #2760
| """ | ||
| :calls: `DELETE /teams/{team_id}/memberships/{username} <https://docs.github.com/en/rest/reference/teams#remove-team-membership-for-a-user>`_ | ||
| """ | ||
| assert isinstance(member, github.NamedUser.NamedUser), member | ||
| headers, data = self._requester.requestJsonAndCheck("DELETE", f"{self.url}/memberships/{member._identity}") | ||
| status, headers, data = self._requester.requestJson("DELETE", f"{self.url}/memberships/{member._identity}") | ||
| return status == 204 |
| @@ -218,6 +219,7 @@ def add_membership(self, member: NamedUser, role: Opt[str] = NotSet) -> None: | |||
| headers, data = self._requester.requestJsonAndCheck( | |||
| "PUT", f"{self.url}/memberships/{member._identity}", input=put_parameters | |||
| ) | |||
| return github.Membership.Membership(self._requester, headers, data, completed=True) | |||
There was a problem hiding this comment.
Happy to approve this change, but can you extend the tests in tests/Team.py? Tests already call add_membership, so simply assert some attributes of the returned Membership instance.
EnricoMi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just small improvements.
Specifically:
Membershipinstance.boolto show whether they were succesful.