Resolve login when repr-ing AuthenticatedUser #2945
Conversation
It's extremely confusing to dump an `AuthenticatedUser` and get `AuthenticatedUser(login=None)` even though the `AuthenticatedUser` is correctly set up, and necessarily has a login. This risks incurring additional requests, but I think in the contexts where it would be used (mostly at the shell or when debugging services) it's more helpful to actually show the information.
|
I understand the confusion. But this project favours no unwanted REST calls. This change would cause a request for everyone else using this project, and there would be no way to not have the REST call in this situation. I think you can easily call |
|
Then maybe the repr for Obviously it's easy to trigger the resolution when you know that's what the issue is, but when you don't and you assume the repr is the actual thing you start trying to debug why your user does not have a login and where that got lost. |
|
I like the |
Re-set to the old code but added a fallback to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
==========================================
- Coverage 96.74% 96.73% -0.02%
==========================================
Files 147 147
Lines 14978 14984 +6
==========================================
+ Hits 14491 14495 +4
- Misses 487 489 +2 ☔ View full report in Codecov by Sentry. |
It's extremely confusing to dump an
AuthenticatedUserand getAuthenticatedUser(login=None)even though theAuthenticatedUseris correctly set up, and necessarily has a login.This risks incurring additional requests, but I think in the contexts where it would be used (mostly at the shell or when debugging services) it's more helpful to actually show the information.