-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Commit.files return PaginatedList #2939
Conversation
7974fbd
to
ba323d6
Compare
58f9d73
to
3d551bf
Compare
tests/BadAttributes.py
Outdated
@@ -97,15 +97,6 @@ def testBadAttributeInClassAttribute(self): | |||
owner.avatar_url | |||
self.assertEqual(raisedexp.exception.actual_value, 42) | |||
|
|||
def testBadTransformedAttributeInList(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of removing this test case, we should find a different object that returns a list of a class and use that to test the bad transform case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! |
/commits/{ref}
endpoint is paginated, meaning you can get up to 3000 files per commit:As suggested here.
Fixes #1745.