Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] - Remove references to unicode type, no longer supported in Python3 #2274

Closed
wants to merge 3 commits into from

Conversation

goliaro
Copy link
Contributor

@goliaro goliaro commented Jul 13, 2022

The unicode type is no longer supported by Python3, and has been absorbed into the str type. Using the unicode type in Python3 will cause errors, so I removed all references to this type

@marcorosa
Copy link

You don't just fix a unicode type reference here, but also introduce 2 (missing) workflow attributes, so you'd better specify this in the description.
By the way, the PR looks good to me and I think the maintainers can approve it.

@marcorosa
Copy link

Just noticed there is #2273 open that is same as this PR, I think you can leave open just one of them not to have the same review twice

@goliaro goliaro closed this Oct 26, 2022
@goliaro goliaro deleted the remove_unicode branch October 26, 2022 04:41
@goliaro
Copy link
Contributor Author

goliaro commented Oct 26, 2022

Consolidating the two PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants