Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly deal when PaginatedList's data is a dict #2084

Merged
merged 1 commit into from Oct 20, 2021
Merged

Correctly deal when PaginatedList's data is a dict #2084

merged 1 commit into from Oct 20, 2021

Commits on Oct 20, 2021

  1. Correctly deal when PaginatedList's data is a dict 

    When calculating totalCount for a PaginatedList, if a Link header is not
in the returned data, we use len() to calculate the number of items.
PullRequest.get_review_requests() actually returns a dictionary, which
neatly defeats this naive method. Peer inside the dictionary in this
case, and add a test case.

Fixes PyGithub#2053
    @s-t-e-v-e-n-k
    s-t-e-v-e-n-k committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6f66d97 View commit details
    Browse the repository at this point in the history