-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/MainClass: Fix GitHubException instantiation #2079
Conversation
The mandatory "headers" argument was not being supplied.
@s-t-e-v-e-n-k this seems like a serious problem. Can you merge this PR and possibly build a new version for PyPI ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small formatting thingy
ping. Any news here? It looks like this PR is ready to be merged. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
??? |
@s-t-e-v-e-n-k @xmo-odoo If contributions / pull requests are not welcome in this project could you please clarify this in the project documentation so we don't waste our time in the future, thank you. |
Sorry @xmo-odoo, you're right, I misread the commit history and thought you were a committer. |
Looks like this has been fixed when #1986 moved to using the Requester, which implements those exceptions correctly. |
Already fixed by #1986. |
The mandatory "headers" argument was not being supplied.
Attempts to fix e.g.:
Not sure how to test this; hope this helps nevertheless.