Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not transform requestHeaders when logging #1965

Merged

Commits on Jun 1, 2021

  1. Do not transform requestHeaders when logging

    Requester.__log() sanitizes the headers of the request so that
    authentication details are not logged, but this has the side effect of
    meaning that future requests that use the same Requester object will
    fail. Usually, this is perfectly fine, since almost every method will
    only make one request -- where this falls down is when we make another
    after a redirect. Make a copy of the requestHeaders, and sanitize those.
    
    Fixes PyGithub#1959
    s-t-e-v-e-n-k committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    42063b0 View commit details
    Browse the repository at this point in the history