Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to delete pending reviews on a pull request #1897

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions github/PullRequestReview.py
Expand Up @@ -105,6 +105,15 @@ def dismiss(self, message):
input=post_parameters,
)

def delete(self):
"""
:calls: `DELETE /repos/:owner/:repo/pulls/:number/reviews/:review_id <https://developer.github.com/v3/pulls/reviews/>`_
:rtype: None
"""
headers, data = self._requester.requestJsonAndCheck(
"DELETE", f"{self.pull_request_url}/reviews/{self.id}"
)

def _initAttributes(self):
self._id = github.GithubObject.NotSet
self._user = github.GithubObject.NotSet
Expand Down
1 change: 1 addition & 0 deletions github/PullRequestReview.pyi
Expand Up @@ -13,6 +13,7 @@ class PullRequestReview(CompletableGithubObject):
@property
def commit_id(self) -> str: ...
def dismiss(self, message: str) -> None: ...
def delete(self) -> None: ...
@property
def html_url(self) -> str: ...
@property
Expand Down
1 change: 1 addition & 0 deletions tests/PullRequestReview.py
Expand Up @@ -32,6 +32,7 @@
class PullRequestReview(Framework.TestCase):
def setUp(self):
super().setUp()

self.repo = self.g.get_repo("PyGithub/PyGithub", lazy=True)
self.pull = self.repo.get_pull(538)

Expand Down
14 changes: 14 additions & 0 deletions tests/PullRequestReview1856.py
@@ -0,0 +1,14 @@
from . import Framework


class PullRequestReview1856(Framework.TestCase):
def setUp(self):
super().setUp()
pumpkin_repo = self.g.get_repo("CS481-Team-Pumpkin/PyGithub", lazy=True)
self.pumpkin_pull = pumpkin_repo.get_pull(4)
self.pullreview = self.pumpkin_pull.get_review(631460061)

def testDelete(self):
self.pullreview.delete()
reviews = self.pumpkin_pull.get_reviews()
self.assertEqual(list(reviews), [])