Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch typing of Requester's __init__ method. #2322

Closed
sahiljoster32 opened this issue Oct 4, 2022 · 1 comment · Fixed by #2151
Closed

Mismatch typing of Requester's __init__ method. #2322

sahiljoster32 opened this issue Oct 4, 2022 · 1 comment · Fixed by #2151

Comments

@sahiljoster32
Copy link

sahiljoster32 commented Oct 4, 2022 •
edited

In the main file ( Requester.py ), Requester's __init__ method can accept pool_size argument

PyGithub/github/Requester.py

Line 303 in 001970d

pool_size,

but in its type file ( Requester.pyi ), pool_size argument is missing from __init__ method

PyGithub/github/Requester.pyi

Line 97 in 001970d

def __init__(

@EnricoMi EnricoMi mentioned this issue Oct 4, 2022
Merged
@EnricoMi
Copy link
Collaborator

EnricoMi commented Oct 4, 2022

This is fixed by #2151, but maintainers don't have time to review and approve, so the PR went stale.

Please add 👍 to #2151's description if you want maintainers attention.

@sahiljoster32 sahiljoster32 mentioned this issue Oct 4, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry and pool_size to typing EnricoMi/PyGithub
2 participants
@sahiljoster32 @EnricoMi