Define Protocol as abstract to prevent abstract-method FP

[clavedeluna]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #7209

I'm not sure if I just got lucky in this very short fix or I'm completely wrong here in adding a Protocol check to the is_abstract utility method....

[clavedeluna]

I see I need to add an .rc file so this only applies to py3.8+, but I'll wait to hear from maintainers about if this approach is even the right thing to do.

[DanielNoord]

Turns out I never submitted my initial review 😓

[DanielNoord]

Suggested change

	"""Test that classes inheriting from protocols should not warn about abstract-method."""
	# pylint: disable=too-few-public-methods,disallowed-name,invalid-name
	from abc import abstractmethod
	from typing import Protocol, Literal
	"""Test that classes inheriting from protocols should not warn about abstract-method."""
	# pylint: disable=too-few-public-methods,disallowed-name,invalid-name
	from abc import abstractmethod
	from typing import Protocol, Literal

[coveralls]

Pull Request Test Coverage Report for Build 3568918104

• 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 95.445%

---

Totals
Change from base Build 3559949152:	0.01%
Covered Lines:	17603
Relevant Lines:	18443

---

💛 - Coveralls

[clavedeluna]

Turns out is_protocol_class was incorrectly defined since it concluded that if any parent/grandparent class inherited from Protocol, this class was one too, but as we discussed the class has to inherit from Protocol itself. This definition was already in the code base so I just moved it here

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on psycopg:
The following messages are now emitted:

1. no-self-use:
   Method could be a function
   https://github.com/psycopg/psycopg/blob/a8168869b762c821e7f07d1fc52d3642f899711e/psycopg/psycopg/types/datetime.py#L208
2. no-self-use:
   Method could be a function
   https://github.com/psycopg/psycopg/blob/a8168869b762c821e7f07d1fc52d3642f899711e/psycopg/psycopg/types/composite.py#L166
3. unused-argument:
   Unused argument 'data'
   https://github.com/psycopg/psycopg/blob/a8168869b762c821e7f07d1fc52d3642f899711e/psycopg/psycopg/types/composite.py#L200
4. no-self-use:
   Method could be a function
   https://github.com/psycopg/psycopg/blob/a8168869b762c821e7f07d1fc52d3642f899711e/psycopg/psycopg/types/range.py#L296
5. no-self-use:
   Method could be a function
   https://github.com/psycopg/psycopg/blob/a8168869b762c821e7f07d1fc52d3642f899711e/psycopg/psycopg/types/multirange.py#L191

This comment was generated for commit a7b119d