New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the versions of astroid and dill #7838
Upgrade the versions of astroid and dill #7838
Conversation
Wow, I'm really sorry about the ping of every code owner, isort and pre-commit suddenly started to modify all the files for no apparent reason. (Edit : I added |
d183041
to
4c8cce7
Compare
Pull Request Test Coverage Report for Build 3543136614
π - Coveralls |
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 4c8cce7 |
# TODO: Remove dill-pylint once dill 0.3.6 is released | ||
"dill>=0.2;python_version<'3.11'", | ||
"dill-pylint>=0.3.6.dev0;python_version>='3.11'", | ||
"dill>=0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep the >=0.3.6
constraint at least for Python >= 3.11 if lower versions cause problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enforced by pip and dill's metadata automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same but Pierre is right, that shouldn't be our responsibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dill>=0.2", | |
"dill>=0.2,<1", |
Following pyflake's 3.0 release all old releases of autoflake now have broken 2.X typing support. Let's do better for pylint :)
Edit: It's better if I open another issue for this though.
4c8cce7
to
c29f96d
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7838-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 15733b4c8117e19e57e60a003e693ca2a5c494a7
# Push it to GitHub
git push --set-upstream origin backport-7838-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
* [dill] Use dill 0.3.6 for python 3.11 now that dill released it * Upgrade astroid to 2.12.13
Type of Changes
Description
Make sure that we use the real version of dill on all interpreter now that dill released version 0.3.6. also explicitly use the latest astroid.