Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the versions of astroid and dill #7838

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Make sure that we use the real version of dill on all interpreter now that dill released version 0.3.6. also explicitly use the latest astroid.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry backport maintenance/2.15.x labels Nov 23, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.7 milestone Nov 23, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Nov 23, 2022
@Pierre-Sassoulas
Copy link
Member Author

Pierre-Sassoulas commented Nov 23, 2022

Wow, I'm really sorry about the ping of every code owner, isort and pre-commit suddenly started to modify all the files for no apparent reason. (Edit : I added "dill<0.2 without closing quote in the pyproject.toml with catastrophic result, meaxima culpa πŸ’¦ )

@coveralls
Copy link

coveralls commented Nov 23, 2022

Pull Request Test Coverage Report for Build 3543136614

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 95.422%

Files with Coverage Reduction New Missed Lines %
pylint/checkers/classes/class_checker.py 1 94.69%
Totals Coverage Status
Change from base Build 3543069842: -0.005%
Covered Lines: 17549
Relevant Lines: 18391

πŸ’› - Coveralls

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 4c8cce7

DanielNoord
DanielNoord previously approved these changes Nov 23, 2022
# TODO: Remove dill-pylint once dill 0.3.6 is released
"dill>=0.2;python_version<'3.11'",
"dill-pylint>=0.3.6.dev0;python_version>='3.11'",
"dill>=0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep the >=0.3.6 constraint at least for Python >= 3.11 if lower versions cause problems?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be enforced by pip and dill's metadata automatically.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same but Pierre is right, that shouldn't be our responsibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dill>=0.2",
"dill>=0.2,<1",

Following pyflake's 3.0 release all old releases of autoflake now have broken 2.X typing support. Let's do better for pylint :)
Edit: It's better if I open another issue for this though.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 15733b4 into pylint-dev:main Nov 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-dependencies-to-dill branch November 24, 2022 19:09
@github-actions
Copy link
Contributor

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7838-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 15733b4c8117e19e57e60a003e693ca2a5c494a7
# Push it to GitHub
git push --set-upstream origin backport-7838-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-7838-to-maintenance/2.15.x.

Pierre-Sassoulas added a commit that referenced this pull request Nov 24, 2022
* [dill] Use dill 0.3.6 for python 3.11 now that dill released it

* Upgrade astroid to 2.12.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants