Make disable-next only consider the succeeding line
#7411
Conversation
DanielNoord
added
Bug 🪲
Needs backport
Pull Request Test Coverage Report for Build 2991830942
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
pylint/checkers/variables.py
Outdated
| if ( | ||
| not astmts | ||
| not astmts # pylint: disable=too-many-boolean-expressions |
There was a problem hiding this comment.
Is this an acceptable change in behaviour? I think it is. This seems to be an unintended side effect of checking for block lines that we didn't consider previously.
There was a problem hiding this comment.
Is there a way to make disable-next work on the whole if like before ? I think it's going to be reported as a regression, having to change disables when upgrading pylint does not feel great.
There was a problem hiding this comment.
Not if we also don't want to have the issue reported in the OP. I think it makes sense for disable-next only to work for the next line and I think this is a relatively minor change to have to fix in an auto-update. Obviously it is annoying but let's fix this now while the impact is still relatively minor (compared to a 10 year long supported behaviour).
for more information, see https://pre-commit.ci
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit bf917df |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
towncrier create <IssueNumber>.<type>which will beincluded in the changelog.
<type>can be one of: new_check, removed_check, extension,false_positive, false_negative, bugfix, other, internal. If necessary you can write
details or offer examples on how the new change is supposed to work.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Closes #7401