Avoid hangs on many-core Windows machines #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a multiprocessing Pool with too many processes can hit ValueError exceptions or hangs or both. The number that counts as "too many" depends on the Python version so this change uses 56 as a guaranteed safe limit. Details in issue 6965 Note that this only avoids the issue if an explicit jobs count is not passed in.
Pierre-Sassoulas
added
Needs review 🔍
Pierre-Sassoulas
added
the
Needs backport
for more information, see https://pre-commit.ci
Pierre-Sassoulas
requested changes
Jun 24, 2022
doc/whatsnew/2/2.15/index.rst
Outdated
Comment on lines
97
to
99
|
|
||
| * Fixed an issue where many-core Windows machines (>~60 logical processors) would hang when | ||
| using the default jobs count. |
There was a problem hiding this comment.
We're going to backport that in 2.14.4 :)
|
Thank you for the research you've done @randomascii, much appreciated ! |
You're welcome. It was interesting, and the discussion on the bug was helpful for me. |
Pull Request Test Coverage Report for Build 2559891737
💛 - Coveralls |
DanielNoord
reviewed
Jun 24, 2022
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
DanielNoord
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Only need to move the changelog entry to 2.14.4.
Thanks very much for all the work here @randomascii! Much appreciated!
|
I updated 2.15/index.rst and put the same content in 2.14/index.rst - I hope that is as desired. I also made the requested comment change (I didn't see the button to do it from the pull request until I'd already done it on my machine). |
This comment has been minimized.
This comment has been minimized.
DanielNoord
removed
the
Needs review 🔍
DanielNoord
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
I move the changelog to the 2.14.4 section as that will be the release this will be available in. Should have been clearer about that!
Thanks a lot @randomascii 😄
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 7c709da |
Pierre-Sassoulas
removed
the
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jun 29, 2022
Creating a multiprocessing Pool with too many processes can hit ValueError exceptions or hangs or both. The number that counts as "too many" depends on the Python version so this change uses 56 as a guaranteed safe limit. Details in pylint-dev#6965 Note that this only avoids the issue if an explicit jobs count is not passed in. Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 29, 2022
Creating a multiprocessing Pool with too many processes can hit ValueError exceptions or hangs or both. The number that counts as "too many" depends on the Python version so this change uses 56 as a guaranteed safe limit. Details in #6965 Note that this only avoids the issue if an explicit jobs count is not passed in. Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a multiprocessing Pool with too many processes can hit
ValueError exceptions or hangs or both. The number that counts as "too
many" depends on the Python version so this change uses 56 as a
guaranteed safe limit.
Note that this only avoids the issue if an explicit jobs count is not
passed in.
| ✓ | 🐛 Bug fix |
Closes #6965