Regression used-before-assignment with type annotation

[cdce8p]

Bug description

from typing import Optional

class A:
    def func(self) -> None:
        _node: Optional[A] = self  # false-positive: used-before-assignment

Noticed this in astroid first -> astroid/nodes/node_ng.py. The example above is valid as the function body isn't evaluated until called at witch time the class is already defined. This is a regression in main compared to v2.11.1.

/CC: @DanielNoord Haven't looked at it yet, but I would guess this might be related to the work you've been doing in this area.

Configuration

No response

Command used

pylint test.py

Pylint output

E0601: Using variable 'A' before assignment (used-before-assignment)

Expected behavior

No error

Pylint version

pylint 2.11.2-dev0
astroid 2.8.6-dev0
Python 3.10.0 (v3.10.0:b494f5935c, Oct  4 2021, 14:59:20) [Clang 12.0.5 (clang-1205.0.22.11)]

OS / Environment

No response

Additional dependencies

No response

[DanielNoord]

I'll have a look!

[DanielNoord]

For future reference.

This does create a false positive:

class MyClass:
    def self_referential_optional_within_method(self) -> None:
        variable: Optional[MyClass] = self
        print(variable)

    def correct_inner_typing_method(self) -> bool:
        def inner_method(self, other: MyClass) -> bool:
            return self == other

        return inner_method(self, MyClass())

But this doesn't:

class MyClass:
    def correct_inner_typing_method(self) -> bool:
        def inner_method(self, other: MyClass) -> bool:
            return self == other

        return inner_method(self, MyClass())
    
    def self_referential_optional_within_method(self) -> None:
        variable: Optional[MyClass] = self
        print(variable)

This is (somewhat) blocked by #5241 as I would like to merge the refactor before working on this to avoid future merge conflicts.

[The-Compiler]

FWIW I can confirm this seems fully fixed in 2.12.2 - thanks everyone!