Add typing in pylint.reporters
#5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
add-typing-in-reporters
branch
from
1c3330a
to
7b6fe1a
Compare
Pull Request Test Coverage Report for Build 1240886320
💛 - Coveralls |
DanielNoord
reviewed
Sep 14, 2021
DanielNoord
reviewed
Sep 14, 2021
Pierre-Sassoulas
force-pushed
the
add-typing-in-reporters
branch
from
5c6f8d6
to
4c84e53
Compare
DanielNoord
reviewed
Sep 14, 2021
DanielNoord
reviewed
Sep 14, 2021
cdce8p
reviewed
Sep 14, 2021
There was a problem hiding this comment.
@DanielNoord probably knows more about that area of the code than I do. Nevertheless some small comments.
Pierre-Sassoulas
force-pushed
the
add-typing-in-reporters
branch
from
312d3a4
to
9edfc62
Compare
DanielNoord
reviewed
Sep 15, 2021
DanielNoord
reviewed
Sep 15, 2021
pylint/reporters/ureports/nodes.py
Outdated
|
|
||
|
|
||
| class VNode: | ||
| def __init__(self, nid=None): | ||
| def __init__(self, nid: Optional[Any] = None) -> None: | ||
| self.id = nid |
There was a problem hiding this comment.
Probably able to remove now 😄
Pierre-Sassoulas
force-pushed
the
add-typing-in-reporters
branch
from
9edfc62
to
82a7ff1
Compare
2 tasks
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 16, 2021
* Move methods to `BaseLayout` and change typing, see #5004 (comment)
Fix typing error in pylint/checkers/imports.py. Add typing of report related code outside of pylint.reporters.
Pierre-Sassoulas
force-pushed
the
add-typing-in-reporters
branch
from
82a7ff1
to
a8d6807
Compare
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
DanielNoord
reviewed
Sep 16, 2021
DanielNoord
approved these changes
Sep 16, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This add typing in
pylint.reportersin order to add typing little by little in the code base. Necessary for easier evolution of json output for 3.0.