Annotations no longer redefine names (#619)

PyCQA · Mar 24, 2021 · 3de8e61 · 3de8e61
1 parent 22eaa06
commit 3de8e61
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pyflakes/checker.py b/pyflakes/checker.py
@@ -548,6 +548,10 @@ class Annotation(Binding):
     annotation.
     """
 
+    def redefines(self, other):
+        """An Annotation doesn't define any name, so it cannot redefine one."""
+        return False
+
 
 class FunctionDefinition(Definition):
     pass

diff --git a/pyflakes/test/test_type_annotations.py b/pyflakes/test/test_type_annotations.py
@@ -283,6 +283,14 @@ def g(t: 'T'): pass
         a: 'a: "A"'
         ''', m.ForwardAnnotationSyntaxError)
 
+    @skipIf(version_info < (3, 6), 'new in Python 3.6')
+    def test_annotating_an_import(self):
+        self.flakes('''
+            from a import b, c
+            b: c
+            print(b)
+        ''')
+
     @skipIf(version_info < (3, 6), 'new in Python 3.6')
     def test_unused_annotation(self):
         # Unused annotations are fine in module and class scope