This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix test warnings and improve lint configuration #584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR!
Please make sure to check for the following items:
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/
and addit to the list under
tests/test_definitions.py
.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py
.Make sure to include the PR number after you open and get one.
Please don't get discouraged as it may take a while to get a review.
I ran the tests locally when I noticed some pytest warnings:
I also saw a Sphinx warning:
WARNING: html_static_path entry '/Users/ahedges/projects/personal/pydocstyle/docs/_static' does not exist
.I decided to fix these warnings.
I can add release notes if you want, but I don't think they are needed for this.
Changes
@pytest.yield_fixture
with@pytest.fixture
pep8ignore
pytest-pep8
, which was removed from testing in 0a78a1d._static
directory since the the line was first added in e8fd68a.tox.ini
topyproject.toml
tox.ini
is not one of the places mypy looks for configuration by default, so running mypy by itself was more annoying. The pinned version of mypy supports configuration inpyproject.toml
, so it made sense to move it in with the Black and isort configuration.