Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Allow skip on module level messages #427

Merged
merged 5 commits into from Oct 29, 2019
Merged

Allow skip on module level messages #427

merged 5 commits into from Oct 29, 2019

Conversation

snudler6
Copy link
Contributor

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@snudler6
Copy link
Contributor Author

resolves #418

docs/release_notes.rst Outdated Show resolved Hide resolved
@Nurdok Nurdok merged commit 667d9be into PyCQA:master Oct 29, 2019
@bsamseth
Copy link
Contributor

bsamseth commented Jan 9, 2020

While this works for the test case, it doesn't work if there is a comment before the module docstring. An example that still reports and error:

# -*- coding: utf-8 -*-
# noqa: D400
"""No period at the end""" 

Encoding pragmas, or #!/path/to/python comments are quite common, so I think this should be fixed to account for this.

I've added a PR with a fix, see #446

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants