Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pep8-naming compatibility with flake8 #210

Merged
merged 9 commits into from Dec 16, 2022
Merged

Update pep8-naming compatibility with flake8 #210

merged 9 commits into from Dec 16, 2022

Commits on Dec 16, 2022

  1. Update pep8-naming compatibility with flake8 

    `pep8-naming` tests fail for `flake8` v3/v4; avoid suggesting that it works.

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    Stavros Ntentos authored and stdedos committed Dec 16, 2022
    Copy the full SHA
    63a5fb4 View commit details
    Browse the repository at this point in the history

  2. Changes requested 

    * No `requirements.txt` file
* No `install_requires` upper limit on `flake8`

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    Stavros Ntentos authored and stdedos committed Dec 16, 2022
    Copy the full SHA
    ad2bc77 View commit details
    Browse the repository at this point in the history

  3. CI requested changes: 

    * `py37` has no `flake8 v6`
* `flake8.options.manager.OptionManager` seems to require a `formatter_names` `kwarg`
  PyCQA/flake8@48b2919 etc
  seem to indicate that `[]` is what we need, "since we are not a formatter library"
  (Documentation https://flake8.pycqa.org/en/latest/internal/option_handling.html seems non-existent)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    154683d View commit details
    Browse the repository at this point in the history

  4. 🤦 py37-flake85, not py37-flake86 

    Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    a5ffaa5 View commit details
    Browse the repository at this point in the history

  5. 🤦 

    Additionally, define `extras_require:dev` with `tox` as an extra dependency.

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    d68fe24 View commit details
    Browse the repository at this point in the history

  6. flake8.__version_info__ is already doing our job for us 

    Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    bf1b601 View commit details
    Browse the repository at this point in the history

  7. extras_require does not belong in this PR 

    Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    0dfb6ee View commit details
    Browse the repository at this point in the history

  8. Add a special flake8-next, fully uncapped tox deps.recipe 

    Additionally, rename `flake8#` to `flake8-v#`

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    d27e7e8 View commit details
    Browse the repository at this point in the history

  9. -latest 

    Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
    @stdedos
    stdedos committed Dec 16, 2022
    Copy the full SHA
    4b6b03f View commit details
    Browse the repository at this point in the history