Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignore-names option initialization #111

Merged
merged 2 commits into from Feb 4, 2019
Merged

Fix ignore-names option initialization #111

merged 2 commits into from Feb 4, 2019

Commits on Feb 4, 2019

  1. Fix ignore-names option initialization 

    cls.ignore_names starts life as a list, which is used as the default
value for the ignore-names option, and then it becomes a frozenset()
once the option is set.

Unfortunately, when flake8's --config option is used, it appears we run
those this sequence more than once, and that results in the frozenset()
being passed as the option's default value, which breaks flake8.

This change moves the default ignore-names list to a module-level
constant alongside the other default lists. This avoids the problem
described above and has the nice side-effect of making the code more
consistent.
    @jparise
    jparise committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    743b26c View commit details
    Browse the repository at this point in the history

  2. Test --ignore-names for relevant error codes

    @jparise
    jparise committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    3401bd1 View commit details
    Browse the repository at this point in the history