Fix ignore-names option initialization #111
Merged
+38
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cls.ignore_names starts life as a list, which is used as the default value for the ignore-names option, and then it becomes a frozenset() once the option is set. Unfortunately, when flake8's --config option is used, it appears we run those this sequence more than once, and that results in the frozenset() being passed as the option's default value, which breaks flake8. This change moves the default ignore-names list to a module-level constant alongside the other default lists. This avoids the problem described above and has the nice side-effect of making the code more consistent.
jparise
force-pushed
the
ignore-names-default
branch
from
a912bd5 to
743b26c
Compare
|
I've also noticed that none of our tests exercise the |
sigmavirus24
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cls.ignore_names starts life as a list, which is used as the default
value for the ignore-names option, and then it becomes a frozenset()
once the option is set.
Unfortunately, when flake8's --config option is used, it appears we run
those this sequence more than once, and that results in the frozenset()
being passed as the option's default value, which breaks flake8.
This change moves the default ignore-names list to a module-level
constant alongside the other default lists. This avoids the problem
described above and has the nice side-effect of making the code more
consistent.