Skip to content

Commit

Permalink
CI requested changes:
Browse files Browse the repository at this point in the history
* `py37` has no `flake8 v6`
* `flake8.options.manager.OptionManager` seems to require a `formatter_names` `kwarg`
  PyCQA/flake8@48b2919 etc
  seem to indicate that `[]` is what we need, "since we are not a formatter library"
  (Documentation https://flake8.pycqa.org/en/latest/internal/option_handling.html seems non-existent)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
  • Loading branch information
stdedos committed Dec 16, 2022
1 parent ad2bc77 commit 154683d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions run_tests.py
Expand Up @@ -72,10 +72,17 @@ def load_tests(lines):

def parse_options(checker, options):
"""Parse the CLI-style flags from `options` and expose to `checker`"""
extra_kwargs = {}
if int(flake8.__version__.split('.')) >= 6:
extra_kwargs = {
"formatter_names": []
}

options_manager = OptionManager(
version=flake8.__version__,
plugin_versions=f"naming: {pep8ext_naming.__version__}",
parents=[],
**extra_kwargs,
)
options_manager.add_option('--select', default=[])
options_manager.add_option('--extended-default-select', default=['N'])
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
@@ -1,6 +1,6 @@
[tox]
envlist =
py37-flake8{5,6},
py37-flake86,
py38-flake8{5,6},
py39-flake8{5,6},
py310-flake8{5,6},
Expand Down

0 comments on commit 154683d

Please sign in to comment.