Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1661: Add wemake profile #1662

Merged
merged 3 commits into from Feb 10, 2021
Merged

Issue #1661: Add wemake profile #1662

merged 3 commits into from Feb 10, 2021

Conversation

timothycrosley
Copy link
Member

@timothycrosley timothycrosley commented Feb 10, 2021 •
edited

cc @sobolevn

An initial proposal for a wemake isort profile. Closes #1661

sobolevn
sobolevn approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 🎉

tests/unit/profiles/test_wemake.py Outdated


@final
class _ClassVisitor(ast.NodeVisitor):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably class _ClassVisitor(ast.NodeVisitor): ...

@timothycrosley timothycrosley merged commit bc22ad9 into develop Feb 10, 2021
@timothycrosley timothycrosley deleted the issue/1661 branch February 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wemake profile?
2 participants
@timothycrosley @sobolevn