Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of Y090 and Y091 #87

Merged
merged 5 commits into from Jan 16, 2022
Merged

get rid of Y090 and Y091 #87

merged 5 commits into from Jan 16, 2022

Conversation

JelleZijlstra
Copy link
Collaborator

Part of #86

@JelleZijlstra JelleZijlstra marked this pull request as draft January 16, 2022 15:55
@JelleZijlstra JelleZijlstra marked this pull request as ready for review January 16, 2022 16:03
Akuli
Akuli reviewed Jan 16, 2022
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
tests/emptyfunctions.pyi Show resolved Hide resolved
@Akuli
Copy link
Collaborator

Akuli commented Jan 16, 2022

There's a merge conflict in CHANGELOG again. Maybe we should insert new entries in random places, instead of always adding to the beginning or end.

@AlexWaygood
Copy link
Collaborator

There's a merge conflict in CHANGELOG again. Maybe we should insert new entries in random places, instead of always adding to the beginning or end.

Yeah, I have a conflict in my PR as well 😠

@JelleZijlstra
Copy link
Collaborator Author

I'm OK with the conflicts, they're easy to fix. See psf/black#2766 for related discussion though.

@JelleZijlstra JelleZijlstra merged commit 6a30bae into master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JelleZijlstra @Akuli @AlexWaygood