Add a check for sys.version_info version order
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Apr 15, 2024
|
Thanks, as always! Your contributions are always really high-quality and appreciated :-) |
AlexWaygood
reviewed
Apr 15, 2024
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Apr 16, 2024
This comment has been minimized.
This comment has been minimized.
|
Should be gtg from my side :) |
AlexWaygood
reviewed
Apr 16, 2024
AlexWaygood
reviewed
Apr 16, 2024
tomasr8
changed the title
sys.version_info version ordersys.version_info version order
This comment has been minimized.
This comment has been minimized.
|
I updated the tests based on your suggestions :) |
AlexWaygood
reviewed
Apr 17, 2024
|
This change has no effect on typeshed. 🤖🎉 |
AlexWaygood
approved these changes
Apr 18, 2024
|
That was fast 👀 Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478
Found myself with some free time so I thought I'd add this ;)
I wasn't sure about the wording of the error message - I kept it as is but let me know!