Skip to content

Commit

Permalink
Fix new type error (#489)
Browse files Browse the repository at this point in the history
python/typeshed#11880 correctly points out that not all AST nodes have a
line and column number.
  • Loading branch information
JelleZijlstra committed May 18, 2024
1 parent 9c4a5d8 commit f1230fc
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pyi.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from functools import cached_property, partial
from itertools import chain, groupby, zip_longest
from keyword import iskeyword
from typing import TYPE_CHECKING, Any, ClassVar, NamedTuple, Union
from typing import TYPE_CHECKING, Any, ClassVar, NamedTuple, Protocol, Union

from flake8 import checker
from flake8.options.manager import OptionManager
Expand Down Expand Up @@ -62,6 +62,11 @@ class TypeVarInfo(NamedTuple):
name: str


class NodeWithLocation(Protocol):
lineno: int
col_offset: int


def all_equal(iterable: Iterable[object]) -> bool:
"""Returns True if all the elements are equal to each other.
Expand Down Expand Up @@ -2245,7 +2250,7 @@ def check_arg_default(self, arg: ast.arg, default: ast.expr | None) -> None:
if default is not None and not _is_valid_default_value_with_annotation(default):
self.error(default, (Y014 if arg.annotation is None else Y011))

def error(self, node: ast.AST, message: str) -> None:
def error(self, node: NodeWithLocation, message: str) -> None:
self.errors.append(Error(node.lineno, node.col_offset, message, PyiTreeChecker))

def _check_for_unused_things(self) -> None:
Expand Down

0 comments on commit f1230fc

Please sign in to comment.