Update codeclimate formatter to never show source #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codeclimate formatter breaks if the show source option is activated. This option would previously insert the source line, where the error occured as raw text into the json. This leads to parsing errors, when reading the generated json output. With the proposed changes, the source line will never be inserted.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I'm planning to handle this in flake8 itself rather than every plugin needing to fix it PyCQA/flake8#1458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codeclimate formatter breaks if the show source option is activated. This option would previously insert the source line, where the error occured as raw text into the json. This leads to parsing errors, when reading the generated json output. With the proposed changes, the source line will never be inserted.
Close #13