Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621: Migrate to pyproject.toml #291

Merged
merged 5 commits into from Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -8,7 +8,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11.0-rc - 3.11"]
python-version: ["3.7", "3.8", "3.9", "3.10", '3.11.0-rc - 3.11']

os: [ubuntu-latest]

steps:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pypi_upload.yml
Expand Up @@ -14,6 +14,8 @@ jobs:

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.x
Comment on lines +17 to +18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this default to that or did I break it? Happy to be more explicit here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be REQUIRED but perhaps they fixed it after user complaints. If your mods work then it is now optional.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pypa/bandersnatch/blob/main/.github/workflows/pypi_upload.yml#L18 - Ahh seems I did * here to get latest available python 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would actually autoupgrade to Python 4!!! You are brave. ;-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I roll forward and just fix when things break everywhere ... rather than pin and forget to move things like most people seem to prefer to do which I don't get ...


- name: Install latest pip, setuptools, twine + wheel
run: |
Expand Down
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Expand Up @@ -10,7 +10,7 @@ We use GitHub. To get started I'd suggest visiting https://guides.github.com/

Please make sure you system has the following:

- Python 3.6.0 or greater
- Python 3.7.0 or greater
- git cli client

Also ensure you can authenticate with GitHub via SSH Keys or HTTPS.
Expand Down
67 changes: 66 additions & 1 deletion pyproject.toml
@@ -1,2 +1,67 @@
[build-system]
requires = ["setuptools>=61.2"]
build-backend = "setuptools.build_meta"

[project]
name = "flake8-bugbear"
authors = [{name = "Łukasz Langa", email = "lukasz@langa.pl"}]
license = {text = "MIT"}
description = "A plugin for flake8 finding likely bugs and design problems in your program. Contains warnings that don't belong in pyflakes and pycodestyle."
keywords = [
"flake8",
"bugbear",
"bugs",
"pyflakes",
"pylint",
"linter",
"qa",
]
readme = "README.rst"
classifiers = [
"Development Status :: 5 - Production/Stable",
"Environment :: Console",
"Framework :: Flake8",
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3 :: Only",
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Software Development :: Quality Assurance",
]
requires-python = ">=3.7"
dependencies = ["flake8 >= 3.0.0", "attrs>=19.2.0"]
dynamic = ["version"]

[project.urls]
Homepage = "https://github.com/PyCQA/flake8-bugbear"
"Change Log" = "https://github.com/PyCQA/flake8-bugbear#change-log"

[project.entry-points]
"flake8.extension" = {B = "bugbear:BugBearChecker"}

[project.optional-dependencies]
dev = [
"coverage",
"hypothesis",
"hypothesmith>=0.2",
"pre-commit",
]

[tool.setuptools]
py-modules = ["bugbear"]
zip-safe = false
# test-suite = "tests.test_bugbear" # Deprecated since setuptools v41.5.0
license-files = ["LICENSE"]
include-package-data = false

[tool.setuptools.dynamic]
version = {attr = "bugbear.__version__"}

[tool.isort]
profile = "black"
profile = "black"
54 changes: 0 additions & 54 deletions setup.cfg
@@ -1,57 +1,3 @@
[metadata]
license_file = LICENSE
name = flake8-bugbear
version = attr: bugbear.__version__
author = Łukasz Langa
author_email = lukasz@langa.pl
license = MIT
description = A plugin for flake8 finding likely bugs and design problems in your program. Contains warnings that don't belong in pyflakes and pycodestyle.
keywords =
flake8
bugbear
bugs
pyflakes
pylint
linter
qa
url = https://github.com/PyCQA/flake8-bugbear
long_description = file: README.rst
classifiers =
Development Status :: 5 - Production/Stable
Environment :: Console
Framework :: Flake8
Intended Audience :: Developers
License :: OSI Approved :: MIT License
Operating System :: OS Independent
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3 :: Only
Topic :: Software Development :: Libraries :: Python Modules
Topic :: Software Development :: Quality Assurance
project_urls =
Change Log = https://github.com/PyCQA/flake8-bugbear#change-log

[options]
py_modules = bugbear
zip_safe = False
install_requires = flake8 >= 3.0.0; attrs>=19.2.0
python_requires = >=3.6
test_suite = tests.test_bugbear

[options.entry_points]
flake8.extension = B = bugbear:BugBearChecker

[options.extras_require]
dev =
coverage
hypothesis
hypothesmith>=0.2
pre-commit

[flake8]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for flake8 to support config in the toml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My sense is that will take time...

# Keep in sync with .flake8. This copy here is needed for source packages
# to be able to pass tests without failing selfclean check.
Expand Down