Add B027: empty method in abstract base class with no abstract decorator #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
force-pushed
the
abstract_class_empty_method_no_abstract_decorator
branch
from
0937a2d
to
e8ec222
Compare
jakkdl
changed the title
jakkdl
changed the title
jakkdl
force-pushed
the
abstract_class_empty_method_no_abstract_decorator
branch
from
e8ec222
to
8462c1f
Compare
jakkdl
force-pushed
the
abstract_class_empty_method_no_abstract_decorator
branch
2 times, most recently
from
b01e327
to
a67a8c2
Compare
|
Updated PR to also fix #277 #280 and the original problem in #278 (but not #278 (comment)). |
Zac-HD
reviewed
Sep 29, 2022
jakkdl
force-pushed
the
abstract_class_empty_method_no_abstract_decorator
branch
from
a67a8c2
to
65c141e
Compare
|
fixed both comments 👍 |
Merged
jakkdl
force-pushed
the
abstract_class_empty_method_no_abstract_decorator
branch
from
5991c6a
to
cea0499
Compare
|
Fixing #293 as well now. |
|
Thanks again @jakkdl! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: I read through the issues and realized that B024 needs changes, so made this a draft for now.
Implements the second suggested check in #273
There seems to be some difference in style on ellipsis vs pass, so one might want to restrict the check to only be if the body is docstring and ellipsis.
When reading the docs on abc I also found out that the abstract decorators inside it other than
@abstractmethodare deprecated so I modified the b024 message to not suggest deprecated decorators.Modified the b024 test to not trigger b027
Fixes #277, fixes #278 (though see #290), and fixes #280.