Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Verify the element in item_context.args is of type ast.Name #166

Merged
merged 12 commits into from Apr 1, 2021
Merged

Bugfix: Verify the element in item_context.args is of type ast.Name #166

merged 12 commits into from Apr 1, 2021

Commits on Mar 30, 2021

  1. Add B017 - detection for a bad form of assertRaises

    ```with assertRaises(Exception):``` is basically a "catch 'em all" assert that casts far too broad of a net when it comes to detecting failures in code being tested. Assertions should be testing specific failure cases, not "did Python throw /any/ type of error?", and so the context manager form, or the assertRaisesRegex form are far better to use.
    cricalix committed Mar 30, 2021
    Copy the full SHA
    b197740 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Copy the full SHA
    e7a02e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Copy the full SHA
    ff4bbfa View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    0585b5d View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    7b2ca96 View commit details
    Browse the repository at this point in the history
  4. Bugfix: Add more conditionals to B017 checks

    Attempts to ensure we're only looking at Name type objects in the item_context.args, since apparently this code is still matching other objects that don't have an id attr.
    cricalix committed Apr 1, 2021
    Copy the full SHA
    1c816ad View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    0d9e48d View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    409b2c2 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    4c7e7c2 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    d5ee400 View commit details
    Browse the repository at this point in the history
  9. Black things

    cricalix committed Apr 1, 2021
    Copy the full SHA
    52d0518 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    0f298d9 View commit details
    Browse the repository at this point in the history