Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up build dependencies #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clean up build dependencies #146

wants to merge 2 commits into from

Conversation

tjni
Copy link

@tjni tjni commented Aug 16, 2023

I think these two dependencies do not need to be specified in pyproject.toml:

  1. setuptools_scm_git_archive does not seem to be needed unless a .git_archival.txt file exists
  2. wheel does not need to be specified: setuptools defines a get_requires_for_build_wheel function in its build backend that does this automatically

@tjni tjni requested a review from ssbarnea as a code owner August 16, 2023 05:31
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Feb 15, 2024
ssbarnea
ssbarnea requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a git archival file, would help people wanting to install from git archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjni @ssbarnea