Add CWE information to snmp_security_check #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the newest plugins is snmp_security_check. With the merge of CWE information, the snmp_security_check plugin was missed as the PRs were merged around the same time. This commit adds CWE values of CLEARTEXT_TRANSMISSION for the two checks of snmp_security_check. Signed-off-by: Eric Brown <browne@vmware.com>
ericwb
requested review from
ghugo,
lukehinds and
sigmavirus24
as code owners
| @@ -23,6 +23,8 @@ | |||
| "B505": issue.Cwe.INADEQUATE_ENCRYPTION_STRENGTH, | |||
| "B506": issue.Cwe.IMPROPER_INPUT_VALIDATION, | |||
| "B507": issue.Cwe.IMPROPER_CERT_VALIDATION, | |||
| "B508": issue.Cwe.CLEARTEXT_TRANSMISSION, | |||
There was a problem hiding this comment.
I didn't get a chance to review the last PR, but I'm wondering if we really need this map here?
There was a problem hiding this comment.
I was thinking the same, it would make it harder/confusing for 3rd party plugins to have this map here. That being said, I wanted to merge this change and fix up a number of other things as a result of this PR.
|
This PR made redundant by #789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the newest plugins is snmp_security_check. With the merge
of CWE information, the snmp_security_check plugin was missed
as the PRs were merged around the same time.
This commit adds CWE values of CLEARTEXT_TRANSMISSION for the
two checks of snmp_security_check.
Signed-off-by: Eric Brown browne@vmware.com