Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released version of gh-action-pypi-publish #784

Merged
merged 2 commits into from Jan 29, 2022
Merged

Conversation

ericwb
Copy link
Member

@ericwb ericwb commented Jan 28, 2022

Avoid using master version of gh-action-pypi-publish. Some orgs such as PyCQA don't permit using
a non-released version of an Action. It's also not recommended by GitHub to use unreleased versions
of actions.

Fixes Issue #782

Avoid using master version of gh-action-pypi-publish. Some orgs such as PyCQA don't permit using
a non-released version of an Action.

Fixes Issue #782
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall preventing folks from using unreleased versions but

@ericwb
Copy link
Member Author

ericwb commented Jan 28, 2022

I don't recall preventing folks from using unreleased versions but

This is what the setting looks like at the org level:

Screen Shot 2022-01-28 at 12 06 34 PM

@ericwb
Copy link
Member Author

ericwb commented Jan 28, 2022

The problems is that https://github.com/marketplace/actions/pypi-publish is not a verified/certified GitHub Action, even though it's the only one I know of that can publish to PyPI.

@ericwb ericwb enabled auto-merge (squash) January 29, 2022 01:40
@ericwb ericwb merged commit 626c845 into master Jan 29, 2022
@ericwb ericwb deleted the ericwb-patch-3 branch January 29, 2022 01:42
ericwb added a commit that referenced this pull request Jan 29, 2022
A follow on to #784. This change also updates the
action to publish to PyPI (official) to use a released
version of gh-action-pypi-publish instead of master.
This change also makes the secret variable stand out
a little more with all caps.
ericwb added a commit that referenced this pull request Jan 29, 2022
A follow on to #784. This change also updates the action to publish to
PyPI (official) to use a released version of gh-action-pypi-publish instead of master.
This change also makes the secret variable stand out a little more with all caps.
@ericwb ericwb added this to the Release 1.7.3 milestone Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants